Skip to content

discord: Ignore old message edits#199

Open
soliton- wants to merge 1 commit intomatterbridge-org:masterfrom
soliton-:soliton-discord-ignore-edits
Open

discord: Ignore old message edits#199
soliton- wants to merge 1 commit intomatterbridge-org:masterfrom
soliton-:soliton-discord-ignore-edits

Conversation

@soliton-
Copy link
Copy Markdown

Since discord occasionally sends spurious message edits for old messages make it possible to ignore those older than MaxEditDays.

Based on https://github.com/42wim/matterbridge/pull/2239/changes and discussion in #132.

Since discord occasionally sends spurious message edits for old messages make it possible to ignore those older than MaxEditDays.
@soliton- soliton- force-pushed the soliton-discord-ignore-edits branch from 9a4ffca to 92e1510 Compare April 15, 2026 13:17
@poVoq
Copy link
Copy Markdown
Collaborator

poVoq commented Apr 15, 2026

Great. Do you think it would be hard to make the max edit duration configurable?

Also, we need a changelog entry and documentation in the Discord bridge docs for it.

Thanks.

@soliton-
Copy link
Copy Markdown
Author

Great. Do you think it would be hard to make the max edit duration configurable?

Based on #132 (comment) I believe that is already in. Still needs a default and probably a special value like -1 to disable.

Also, we need a changelog entry and documentation in the Discord bridge docs for it.

I'll figure out what that means. Ideally I'd like to know how to handle the lint issue and have confirmation on the config setting before documenting it.

Well, actually I just asked on IRC about the lint issue. The same code the linter mentions already exists in the pre-existing line above and there are more cases in the file as far as I can tell so it might be weird to just change one instance? How is that normally handled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants